Will-Lo commented on code in PR #3797:
URL: https://github.com/apache/gobblin/pull/3797#discussion_r1353315562
##########
gobblin-runtime/src/main/java/org/apache/gobblin/runtime/api/MysqlMultiActiveLeaseArbiter.java:
##########
@@ -359,10 +366,13 @@ else if (leaseValidityStatus == 2) {
* Checks leaseArbiterTable for an existing entry for this flow action and
event time
*/
protected Optional<GetEventInfoResult>
getExistingEventInfo(DagActionStore.DagAction flowAction,
- boolean isReminderEvent) throws IOException {
+ boolean isReminderEvent, long eventTimeMillis) throws IOException {
return withPreparedStatement(isReminderEvent ?
thisTableGetInfoStatementForReminder : thisTableGetInfoStatement,
getInfoStatement -> {
int i = 0;
+ if (isReminderEvent) {
Review Comment:
Why not get the timestamp regardless if it's a reminder event or not? Seems
useful
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
