arjun4084346 commented on code in PR #3799:
URL: https://github.com/apache/gobblin/pull/3799#discussion_r1358961110
##########
gobblin-data-management/src/main/java/org/apache/gobblin/data/management/copy/iceberg/IcebergTable.java:
##########
@@ -202,4 +204,15 @@ protected void registerIcebergTable(TableMetadata
srcMetadata, TableMetadata dst
this.tableOps.commit(dstMetadata,
srcMetadata.replaceProperties(dstMetadata.properties()));
}
}
+
+ /**
+ * Provides absolute path of the iceberg table location
+ * @return string value of table location if present
+ * @throws TableNotFoundException
+ */
+ public String getTablePath() throws TableNotFoundException {
+ Path tablePath = Paths.get(accessTableMetadata().location());
+ log.info("Iceberg table location: {}", tablePath.toAbsolutePath());
Review Comment:
in my opinion, every get call should not log the entity being returned.
setters may log
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
