[jira] [Work logged] (GOBBLIN-1930) Improve Logs & Metrics around Multi-active Launch Handling

[ASF GitHub Bot (Jira)]

     [ 
https://issues.apache.org/jira/browse/GOBBLIN-1930?focusedWorklogId=885444&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-885444
 ]

ASF GitHub Bot logged work on GOBBLIN-1930:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 16/Oct/23 17:52
            Start Date: 16/Oct/23 17:52
    Worklog Time Spent: 10m 
      Work Description: umustafi commented on code in PR #3800:
URL: https://github.com/apache/gobblin/pull/3800#discussion_r1361054688


##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/DagManager.java:
##########
@@ -510,13 +510,18 @@ public void 
handleLaunchFlowEvent(DagActionStore.DagAction launchAction) {
       this.dagActionStore.get().deleteDagAction(launchAction);
     } catch (URISyntaxException e) {
       log.warn("Could not create URI object for flowId {} due to exception 
{}", flowId, e.getMessage());
+      this.dagManagerMetrics.incrementFailedLaunchCount();
     } catch (SpecNotFoundException e) {
       log.warn("Spec not found for flowId {} due to exception {}", flowId, 
e.getMessage());
+      this.dagManagerMetrics.incrementFailedLaunchCount();
     } catch (IOException e) {
       log.warn("Failed to add Job Execution Plan for flowId {} OR delete dag 
action from dagActionStore (check "
           + "stacktrace) due to exception {}", flowId, e.getMessage());
+      this.dagManagerMetrics.incrementFailedLaunchCount();
     } catch (InterruptedException e) {
-      log.warn("SpecCompiler failed to reach healthy state before compilation 
of flowId {}. Exception: ", flowId, e);
+      log.warn("SpecCompiler failed to reach healthy state before compilation 
of flowId {} due to exception {}", flowId,
+          e);

Review Comment:
   There are two `{}` and the last one is for the throwable so it will print 
the `getMessage`. I updated all the methods to use `Logger::warn(String, 
Throwable)` thought to get full stack trace. 





Issue Time Tracking
-------------------

    Worklog Id:     (was: 885444)
    Time Spent: 1h  (was: 50m)

> Improve Logs & Metrics around Multi-active Launch Handling
> ----------------------------------------------------------
>
>                 Key: GOBBLIN-1930
>                 URL: https://issues.apache.org/jira/browse/GOBBLIN-1930
>             Project: Apache Gobblin
>          Issue Type: Improvement
>          Components: gobblin-service
>            Reporter: Urmi Mustafi
>            Assignee: Abhishek Tiwari
>            Priority: Major
>          Time Spent: 1h
>  Remaining Estimate: 0h
>
> Improve logging and metrics around multi-active launch flow event handling to 
> identify any missing events between the {{MysqlMultiActiveLeaseArbiter}} 
> committing the launch event to the {{dagActionStore}} and the 
> {{DagActionMonitor}} receiving events for processing. We want to be able to 
> distinguish between the following cases of 
>  * events that are never received by the {{DagActionMonitor}}
>  * events incorrectly filtered out by the {{DagActionMonitor}}
>  * any failed submissions of dags to the {{DagManager}} either upon leader 
> change or from the {{DagActionChangeMonitor}}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)