phet commented on code in PR #3800:
URL: https://github.com/apache/gobblin/pull/3800#discussion_r1361230091


##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/Orchestrator.java:
##########
@@ -347,9 +352,13 @@ public void submitFlowToDagManager(FlowSpec flowSpec, 
Dag<JobExecutionPlan> jobE
       //Send the dag to the DagManager.
       this.dagManager.get().addDag(jobExecutionPlanDag, true, true);
     } catch (Exception ex) {
+      String failureMessage = "Failed to add Job Execution Plan due to: " + 
ex.getMessage();
+      _log.warn("Orchestrator call - " + failureMessage);

Review Comment:
   since we don't expect this very frequently, we may prefer to print the stack 
trace rather than merely the exception msg.  (we want as much info to go on as 
possible)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to