[ 
https://issues.apache.org/jira/browse/GOBBLIN-1922?focusedWorklogId=886480&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-886480
 ]

ASF GitHub Bot logged work on GOBBLIN-1922:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 20/Oct/23 18:31
            Start Date: 20/Oct/23 18:31
    Worklog Time Spent: 10m 
      Work Description: hanghangliu commented on code in PR #3798:
URL: https://github.com/apache/gobblin/pull/3798#discussion_r1367372994


##########
gobblin-modules/gobblin-kafka-common/src/main/java/org/apache/gobblin/source/extractor/extract/kafka/KafkaSource.java:
##########
@@ -306,6 +303,96 @@ public String apply(KafkaTopic topic) {
     }
   }
 
+  public List<WorkUnit> getWorkunitsForFilteredPartitions(SourceState state, 
Map<String, List<String>> filteredTopicPartitionMap, int minContainer) {

Review Comment:
   My next PR will be utilizing this minContainer in 
KafkaTopicGroupingWorkUnitPacker, which is not being respected in the current 
implementation.





Issue Time Tracking
-------------------

    Worklog Id:     (was: 886480)
    Time Spent: 50m  (was: 40m)

> Create work units for selected topics partitions in Kafka source
> ----------------------------------------------------------------
>
>                 Key: GOBBLIN-1922
>                 URL: https://issues.apache.org/jira/browse/GOBBLIN-1922
>             Project: Apache Gobblin
>          Issue Type: New Feature
>          Components: gobblin-kafka
>            Reporter: Hanghang Liu
>            Assignee: Shirshanka Das
>            Priority: Major
>          Time Spent: 50m
>  Remaining Estimate: 0h
>
> Add a new feature in Kafka source to create workUnit for selected topics 
> partitions. This feature can provide functionality for:
>  # Recompute and split tasks(workUnit) during runtime for selected topics 
> partitiions, instead of recompute for all Kafka topics
>  # Make topic level replan feasible
>  # One step closer to dynamic work unit allocation 
> Need to have a followup to make work unit packer able to pack the recomputed 
> workunits into a desired number of containers 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to