[
https://issues.apache.org/jira/browse/GOBBLIN-1931?focusedWorklogId=886500&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-886500
]
ASF GitHub Bot logged work on GOBBLIN-1931:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 20/Oct/23 21:09
Start Date: 20/Oct/23 21:09
Worklog Time Spent: 10m
Work Description: Will-Lo commented on code in PR #3801:
URL: https://github.com/apache/gobblin/pull/3801#discussion_r1367463523
##########
gobblin-service/src/main/java/org/apache/gobblin/service/monitoring/DagActionStoreChangeMonitor.java:
##########
@@ -216,7 +217,7 @@ protected void submitFlowToDagManagerHelper(String
flowGroup, String flowName) {
@Override
protected void createMetrics() {
- super.createMetrics();
+ super.messagesRead =
this.getMetricContext().counter(ServiceMetricNames.GOBBLIN_SERVICE_PREFIX +
RuntimeMetrics.GOBBLIN_KAFKA_HIGH_LEVEL_CONSUMER_MESSAGES_READ);
Review Comment:
If we're calling it here is there any different creating a counter vs a
contextawarecounter?
Issue Time Tracking
-------------------
Worklog Id: (was: 886500)
Time Spent: 20m (was: 10m)
> Refactor dag action method & add clarifying comment
> ---------------------------------------------------
>
> Key: GOBBLIN-1931
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1931
> Project: Apache Gobblin
> Issue Type: Improvement
> Components: gobblin-service
> Reporter: Urmi Mustafi
> Assignee: Abhishek Tiwari
> Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Small refactor to improve coding style of updateFlowExecutionId method of
> DagAction. Add an additional clarifying comment to ensure the right
> DagActions are used.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
