Will-Lo commented on code in PR #3801:
URL: https://github.com/apache/gobblin/pull/3801#discussion_r1367463523
##########
gobblin-service/src/main/java/org/apache/gobblin/service/monitoring/DagActionStoreChangeMonitor.java:
##########
@@ -216,7 +217,7 @@ protected void submitFlowToDagManagerHelper(String
flowGroup, String flowName) {
@Override
protected void createMetrics() {
- super.createMetrics();
+ super.messagesRead =
this.getMetricContext().counter(ServiceMetricNames.GOBBLIN_SERVICE_PREFIX +
RuntimeMetrics.GOBBLIN_KAFKA_HIGH_LEVEL_CONSUMER_MESSAGES_READ);
Review Comment:
If we're calling it here is there any different creating a counter vs a
contextawarecounter?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
