arjun4084346 commented on code in PR #3804:
URL: https://github.com/apache/gobblin/pull/3804#discussion_r1370978849


##########
gobblin-data-management/src/main/java/org/apache/gobblin/data/management/copy/publisher/CopyDataPublisher.java:
##########
@@ -300,6 +300,10 @@ private void publishFileSet(CopyEntity.DatasetAndPartition 
datasetAndPartition,
       }
     }
 
+    // execute post publish commit steps after preserving file attributes, 
because some post publish step,
+    // e.g. SetPermissionCommitStep needs to set permissions
+    executeCommitSequence(postPublish);

Review Comment:
   moving from tmp(writer.output.dir actually) to dst is publish step, right? 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to