[
https://issues.apache.org/jira/browse/GOBBLIN-1956?focusedWorklogId=890591&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-890591
]
ASF GitHub Bot logged work on GOBBLIN-1956:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 15/Nov/23 00:51
Start Date: 15/Nov/23 00:51
Worklog Time Spent: 10m
Work Description: ZihanLi58 opened a new pull request, #3827:
URL: https://github.com/apache/gobblin/pull/3827
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I
have checked off all the steps below!
### JIRA
- [ ] My PR addresses the following [Gobblin
JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references
them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
- https://issues.apache.org/jira/browse/GOBBLIN-1956
### Description
- [ ] Here are some details about my PR, including screenshots (if
applicable):
Kafka max.poll.records affect the performance of the Kafka consumer.
Config it to be a lower number means it take more time to process each
record. While config it to be a higher number means we need more memory to hold
the records. So we should use the avg record size to determine the value for
different topics.
We use the max avg record size among all assigned partition to avoid OOM
issue as much as possible.
### Tests
- [ ] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
Unit test and test by running the pipeline
### Commits
- [ ] My commits all reference JIRA issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
2. Subject is limited to 50 characters
3. Subject does not end with a period
4. Subject uses the imperative mood ("add", not "adding")
5. Body wraps at 72 characters
6. Body explains "what" and "why", not "how"
Issue Time Tracking
-------------------
Worklog Id: (was: 890591)
Remaining Estimate: 0h
Time Spent: 10m
> Make Kafka streaming pipeline be able to config the max poll records during
> runtime
> -----------------------------------------------------------------------------------
>
> Key: GOBBLIN-1956
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1956
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: Zihan Li
> Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Kafka max.poll.records affect the performance of the Kafka consumer.
> Config it to be a lower number means it take more time to process each
> record. While config it to be a higher number means we need more memory to
> hold the records. So we should use the avg record size to determine the value
> for different topics.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
