phet commented on code in PR #3840:
URL: https://github.com/apache/gobblin/pull/3840#discussion_r1414446166
##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/utils/FlowCompilationValidationHelper.java:
##########
@@ -86,10 +86,16 @@ public Optional<Dag<JobExecutionPlan>>
createExecutionPlanIfValid(FlowSpec flowS
Map<String, String> flowMetadata =
TimingEventUtils.getFlowMetadata(flowSpec);
if (!jobExecutionPlanDagOptional.isPresent()) {
+ log.warn("No dag execution plan created for flowGroup: {} flowName: {}",
+ flowMetadata.get(TimingEvent.FlowEventConstants.FLOW_GROUP_FIELD),
+ flowMetadata.get(TimingEvent.FlowEventConstants.FLOW_NAME_FIELD));
Review Comment:
if we do anything other than logging the value, I recommend a default (even
when it *should* always be set). for logging only, it's safe enough to print
`null`, when that's what's actually returned.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
