[
https://issues.apache.org/jira/browse/GOBBLIN-1970?focusedWorklogId=893924&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-893924
]
ASF GitHub Bot logged work on GOBBLIN-1970:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 05/Dec/23 00:54
Start Date: 05/Dec/23 00:54
Worklog Time Spent: 10m
Work Description: codecov-commenter commented on PR #3841:
URL: https://github.com/apache/gobblin/pull/3841#issuecomment-1839816194
##
[Codecov](https://app.codecov.io/gh/apache/gobblin/pull/3841?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
Report
All modified and coverable lines are covered by tests :white_check_mark:
> Comparison is base
[(`694ed37`)](https://app.codecov.io/gh/apache/gobblin/commit/694ed37649ce4d48e4f4810287c7245339d19069?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
47.58% compared to head
[(`f90235e`)](https://app.codecov.io/gh/apache/gobblin/pull/3841?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
46.09%.
> Report is 1 commits behind head on master.
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #3841 +/- ##
============================================
- Coverage 47.58% 46.09% -1.49%
+ Complexity 11050 2181 -8869
============================================
Files 2159 416 -1743
Lines 85429 17992 -67437
Branches 9493 2194 -7299
============================================
- Hits 40649 8293 -32356
+ Misses 41080 8815 -32265
+ Partials 3700 884 -2816
```
</details>
[:umbrella: View full report in Codecov by
Sentry](https://app.codecov.io/gh/apache/gobblin/pull/3841?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it
here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
Issue Time Tracking
-------------------
Worklog Id: (was: 893924)
Time Spent: 50m (was: 40m)
> Consolidate Processing Dag Actions to Single Code Path
> ------------------------------------------------------
>
> Key: GOBBLIN-1970
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1970
> Project: Apache Gobblin
> Issue Type: Improvement
> Components: gobblin-service
> Reporter: Urmi Mustafi
> Assignee: Abhishek Tiwari
> Priority: Major
> Time Spent: 50m
> Remaining Estimate: 0h
>
> We have similar code in the DagActionStoreChangeMonitor and DagManager to
> process dag actions from the DagActionStore. There have been small
> discrepancies between the code in each area leading to unexpected bugs in how
> the actions are processed, so to fix forward and make this easier to maintain
> with code in one place we consolidate all logic relating to the dag action
> processing to the DagActionStoreChangeMonitor. The processing in the change
> monitor is working correctly, while the handling of launch events in the
> DagManager is failing compilation most likely due to an error loading the job
> templates when initializing the compiler but we're not able to identify the
> exact issue.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
