arjun4084346 commented on code in PR #3841:
URL: https://github.com/apache/gobblin/pull/3841#discussion_r1428381063
##########
gobblin-service/src/main/java/org/apache/gobblin/service/monitoring/DagActionStoreChangeMonitor.java:
##########
@@ -192,9 +202,53 @@ protected void processMessage(DecodeableKafkaRecord
message) {
dagActionsSeenCache.put(changeIdentifier, changeIdentifier);
}
- protected void submitFlowToDagManagerHelper(DagActionStore.DagAction
dagAction) {
+ /**
+ * For a given dagAction, calls the appropriate method in the DagManager to
carry out the desired action.
+ * @param isStartup true if called for dagAction loaded directly from store
upon startup, false otherwise
+ */
+ private void handleDagAction(DagActionStore.DagAction dagAction, boolean
isStartup) {
+ log.info("(" + (isStartup ? "on-startup" : "post-startup") + ") DagAction
change ({}) received for flow: {}",
+ dagAction.getFlowActionType(), dagAction);
+ if
(dagAction.getFlowActionType().equals(DagActionStore.FlowActionType.RESUME)) {
Review Comment:
On the left side, this piece of code was written with switch-case, now it is
changed to if-else. Why?
IntelliJ complains when if-else is used.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
