[
https://issues.apache.org/jira/browse/GOBBLIN-1970?focusedWorklogId=895893&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-895893
]
ASF GitHub Bot logged work on GOBBLIN-1970:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 15/Dec/23 19:10
Start Date: 15/Dec/23 19:10
Worklog Time Spent: 10m
Work Description: arjun4084346 commented on code in PR #3841:
URL: https://github.com/apache/gobblin/pull/3841#discussion_r1428381063
##########
gobblin-service/src/main/java/org/apache/gobblin/service/monitoring/DagActionStoreChangeMonitor.java:
##########
@@ -192,9 +202,53 @@ protected void processMessage(DecodeableKafkaRecord
message) {
dagActionsSeenCache.put(changeIdentifier, changeIdentifier);
}
- protected void submitFlowToDagManagerHelper(DagActionStore.DagAction
dagAction) {
+ /**
+ * For a given dagAction, calls the appropriate method in the DagManager to
carry out the desired action.
+ * @param isStartup true if called for dagAction loaded directly from store
upon startup, false otherwise
+ */
+ private void handleDagAction(DagActionStore.DagAction dagAction, boolean
isStartup) {
+ log.info("(" + (isStartup ? "on-startup" : "post-startup") + ") DagAction
change ({}) received for flow: {}",
+ dagAction.getFlowActionType(), dagAction);
+ if
(dagAction.getFlowActionType().equals(DagActionStore.FlowActionType.RESUME)) {
Review Comment:
On the left side, this piece of code was written with switch-case, now it is
changed to if-else. Why?
IntelliJ complains when if-else is used.
Issue Time Tracking
-------------------
Worklog Id: (was: 895893)
Time Spent: 3h 10m (was: 3h)
> Consolidate Processing Dag Actions to Single Code Path
> ------------------------------------------------------
>
> Key: GOBBLIN-1970
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1970
> Project: Apache Gobblin
> Issue Type: Improvement
> Components: gobblin-service
> Reporter: Urmi Mustafi
> Assignee: Abhishek Tiwari
> Priority: Major
> Time Spent: 3h 10m
> Remaining Estimate: 0h
>
> We have similar code in the DagActionStoreChangeMonitor and DagManager to
> process dag actions from the DagActionStore. There have been small
> discrepancies between the code in each area leading to unexpected bugs in how
> the actions are processed, so to fix forward and make this easier to maintain
> with code in one place we consolidate all logic relating to the dag action
> processing to the DagActionStoreChangeMonitor. The processing in the change
> monitor is working correctly, while the handling of launch events in the
> DagManager is failing compilation most likely due to an error loading the job
> templates when initializing the compiler but we're not able to identify the
> exact issue.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
