arjun4084346 opened a new pull request, #3887: URL: https://github.com/apache/gobblin/pull/3887
Dear Gobblin maintainers, Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below! ### JIRA - [x] My PR addresses the following [Gobblin JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR" - https://issues.apache.org/jira/browse/GOBBLIN-2009 ### Description - [x] Here are some details about my PR, including screenshots (if applicable): From my observation, setting an ACL may change the file permission if it is not the same as permission. But changing permission does not change the ACLs; it may update the mask value which changes the effective permission of the ACL entry though. Thus in order to achieve same ACL and same permission in destination as source, we should first apply ACLs and then apply permissions. ``` hdfs dfs -ls /tmp/x3 -rw-rwxr-- 3 griddata users 0 2024-02-29 20:15 /tmp/x3 ``` ``` hdfs dfs -getfacl hdfs://ltx1-holdemnn01/tmp/x3 # file: hdfs://ltx1-holdemnn01/tmp/x3 # owner: griddata # group: users user::rw- user:abora:r-x group::rwx mask::rwx other::r-- ``` `hdfs dfs -setfacl -m group::r-x /tmp/x3 ` ``` hdfs dfs -ls /tmp/x3 -rw-r-xr-- 3 griddata users 0 2024-02-29 20:15 /tmp/x3 ``` [permissions changed by changing acl] `hdfs dfs -chmod 674 /tmp/x3 ` [hdfs dfs -getfacl hdfs://ltx1-holdemnn01/tmp/x3 # file: hdfs://ltx1-holdemnn01/tmp/x3 # owner: griddata # group: users user::rw- user:abora:r-x group::r-x mask::rwx other::r--](url) [ACLs did not change, mask changes though] ### Tests - [x] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason: LocalFileSystem does not have ACL feature, so it cannot be tested. ### Commits - [x] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)": 1. Subject is separated from body by a blank line 2. Subject is limited to 50 characters 3. Subject does not end with a period 4. Subject uses the imperative mood ("add", not "adding") 5. Body wraps at 72 characters 6. Body explains "what" and "why", not "how" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
