phet commented on code in PR #3886:
URL: https://github.com/apache/gobblin/pull/3886#discussion_r1509469273
##########
gobblin-temporal/src/main/java/org/apache/gobblin/temporal/ddm/workflow/impl/NestingExecOfProcessWorkUnitWorkflowImpl.java:
##########
@@ -41,7 +41,7 @@ public class NestingExecOfProcessWorkUnitWorkflowImpl extends
AbstractNestingExe
.build();
private static final ActivityOptions ACTIVITY_OPTS =
ActivityOptions.newBuilder()
- .setStartToCloseTimeout(Duration.ofSeconds(999))
+ .setStartToCloseTimeout(Duration.ofMinutes(20))
Review Comment:
I definitely agree on configurability. I added a TODO [over
there](https://github.com/apache/gobblin/pull/3886/files#diff-8b215b0860cefa8c3d067f90482ea09e09bfab64ede78e369c863240e0c28dfaR55)
and can add one here too
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
