umustafi commented on code in PR #3888:
URL: https://github.com/apache/gobblin/pull/3888#discussion_r1509707292
##########
gobblin-runtime/src/main/java/org/apache/gobblin/service/monitoring/FlowStatusGenerator.java:
##########
@@ -153,15 +153,20 @@ public List<FlowStatus> getFlowStatusesAcrossGroup(String
flowGroup, int countPe
* @return true, if any jobs of the flow are RUNNING.
*/
public boolean isFlowRunning(String flowName, String flowGroup, long
flowExecutionId) {
- List<FlowStatus> flowStatusList = getLatestFlowStatus(flowName, flowGroup,
1, null);
+ List<FlowStatus> flowStatusList = getLatestFlowStatus(flowName, flowGroup,
2, null);
if (flowStatusList == null || flowStatusList.isEmpty()) {
return false;
+ }
+ FlowStatus flowStatus = flowStatusList.get(0);
Review Comment:
can you make a comment to make clear that the first one is the most recent
and may or may not match the pending flowExecutionId attempt and the second
index is an older one? It's a bit hard to keep track of what's going on here
without reading ur commit desc
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
