[
https://issues.apache.org/jira/browse/GOBBLIN-1910?focusedWorklogId=909028&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-909028
]
ASF GitHub Bot logged work on GOBBLIN-1910:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 09/Mar/24 00:20
Start Date: 09/Mar/24 00:20
Worklog Time Spent: 10m
Work Description: arjun4084346 commented on code in PR #3858:
URL: https://github.com/apache/gobblin/pull/3858#discussion_r1518427757
##########
gobblin-service/src/test/java/org/apache/gobblin/service/modules/orchestration/DagProcessingEngineTest.java:
##########
@@ -102,34 +102,43 @@ public boolean hasNext() {
}
@Override
- public synchronized DagTask next() {
+ public synchronized DagTask next() throws NoSuchElementException {
i++;
- if (i <= MAX_NUM_OF_TASKS) {
- return new MockedDagTask(new DagActionStore.DagAction("fg-" + i, "fn-"
+ i, "1234" + i, DagActionStore.FlowActionType.LAUNCH), null);
+ if (i > MAX_NUM_OF_TASKS) {
+ throw new RuntimeException("Simulating an exception to stop the
thread!");
Review Comment:
if the test throws exception in MockedDagProc.act , thread will not stop....
i just wanted to stop the DPE thread, though it is not required...
DagProcEngineThread is written in such a way that it will swallow exceptions
(with logging) thrown by dag procs, but will die on any exception in
dagTaskStream.next()
Issue Time Tracking
-------------------
Worklog Id: (was: 909028)
Time Spent: 31.5h (was: 31h 20m)
> Refactor code to move current in-memory references to new design for REST
> calls: Launch, Resume and Kill
> --------------------------------------------------------------------------------------------------------
>
> Key: GOBBLIN-1910
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1910
> Project: Apache Gobblin
> Issue Type: New Feature
> Reporter: Meeth Gala
> Priority: Major
> Time Spent: 31.5h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
