[jira] [Work logged] (GOBBLIN-2022) create dag proc for taking actions on job completion

[ASF GitHub Bot (Jira)]

     [ 
https://issues.apache.org/jira/browse/GOBBLIN-2022?focusedWorklogId=911348&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-911348
 ]

ASF GitHub Bot logged work on GOBBLIN-2022:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 25/Mar/24 17:57
            Start Date: 25/Mar/24 17:57
    Worklog Time Spent: 10m 
      Work Description: phet commented on code in PR #3896:
URL: https://github.com/apache/gobblin/pull/3896#discussion_r1538010430


##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/DagTaskVisitor.java:
##########
@@ -18,8 +18,10 @@
 package org.apache.gobblin.service.modules.orchestration;
 
 import org.apache.gobblin.service.modules.orchestration.task.LaunchDagTask;
+import org.apache.gobblin.service.modules.orchestration.task.ReEvaluateDagTask;
 
 
 public interface DagTaskVisitor<T> {
   T meet(LaunchDagTask launchDagTask);
+  T meet(ReEvaluateDagTask launchDagTask);

Review Comment:
   not `launchDagTask`



##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/DagManagementTaskStreamImpl.java:
##########
@@ -114,8 +115,10 @@ private DagTask createDagTask(DagActionStore.DagAction 
dagAction, MultiActiveLea
     switch (dagActionType) {
       case LAUNCH:
         return new LaunchDagTask(dagAction, leaseObtainedStatus);
+      case REEVALUATE:
+        return new ReEvaluateDagTask(dagAction, leaseObtainedStatus);

Review Comment:
   since "reevaluate"/"Reevaluate" (capitalized), let's spell 
`ReevaluateDagTask`





Issue Time Tracking
-------------------

            Worklog Id:     (was: 911348)
    Remaining Estimate: 0h
            Time Spent: 10m

> create dag proc for taking actions on job completion
> ----------------------------------------------------
>
>                 Key: GOBBLIN-2022
>                 URL: https://issues.apache.org/jira/browse/GOBBLIN-2022
>             Project: Apache Gobblin
>          Issue Type: Task
>            Reporter: Arjun Singh Bora
>            Priority: Major
>          Time Spent: 10m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)