[
https://issues.apache.org/jira/browse/GOBBLIN-2025?focusedWorklogId=911415&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-911415
]
ASF GitHub Bot logged work on GOBBLIN-2025:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 25/Mar/24 22:36
Start Date: 25/Mar/24 22:36
Worklog Time Spent: 10m
Work Description: Will-Lo opened a new pull request, #3903:
URL: https://github.com/apache/gobblin/pull/3903
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I
have checked off all the steps below!
### JIRA
- [ ] My PR addresses the following [Gobblin
JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references
them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
- https://issues.apache.org/jira/browse/GOBBLIN-2025
### Description
- [ ] Here are some details about my PR, including screenshots (if
applicable):
For some use cases of predicates, we want an `alwaysFalse` semantic.
Normally this is easy to import from Guava via `Predicate.alwaysFalse()` but
due to Gobblin relying on classloading this is not feasible.
### Tests
- [ ] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
Trivial class added that can only be enabled via configuration
### Commits
- [ ] My commits all reference JIRA issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
2. Subject is limited to 50 characters
3. Subject does not end with a period
4. Subject uses the imperative mood ("add", not "adding")
5. Body wraps at 72 characters
6. Body explains "what" and "why", not "how"
Issue Time Tracking
-------------------
Worklog Id: (was: 911415)
Remaining Estimate: 0h
Time Spent: 10m
> Add Predicate for alwaysFalse to cover cases where predicates are used but
> can be disabled
> ------------------------------------------------------------------------------------------
>
> Key: GOBBLIN-2025
> URL: https://issues.apache.org/jira/browse/GOBBLIN-2025
> Project: Apache Gobblin
> Issue Type: Improvement
> Components: gobblin-core
> Reporter: William Lo
> Assignee: Abhishek Tiwari
> Priority: Minor
> Time Spent: 10m
> Remaining Estimate: 0h
>
> In Gobblin, since predicates are loaded via Java class loading and have
> minimal configuration options, this is not possible to invoke the Guava
> predicate class of `ObjectPredicate.alwaysFalse()`.
> We want to enable a way for users to have alwaysFalse as a predicate to match
> the alwaysTrue predicate in scenarios where that configuration is needed.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
