[
https://issues.apache.org/jira/browse/GOBBLIN-2022?focusedWorklogId=911486&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-911486
]
ASF GitHub Bot logged work on GOBBLIN-2022:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 26/Mar/24 06:19
Start Date: 26/Mar/24 06:19
Worklog Time Spent: 10m
Work Description: phet commented on code in PR #3896:
URL: https://github.com/apache/gobblin/pull/3896#discussion_r1538580827
##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/proc/DagProc.java:
##########
@@ -46,18 +50,21 @@ public final void process(DagManagementStateStore
dagManagementStateStore) throw
S state = initialize(dagManagementStateStore); // todo - retry
T result = act(dagManagementStateStore, state); // todo - retry
commit(dagManagementStateStore, result); // todo - retry
- sendNotification(result, eventSubmitter); // todo - retry
log.info("{} successfully concluded actions for dagId : {}",
getClass().getSimpleName(), getDagId());
}
- protected abstract DagManager.DagId getDagId();
+ protected DagManager.DagId getDagId() {
+ return this.dagTask.getDagId();
+ }
+
+ protected DagNodeId getDagNodeId() {
+ return this.dagTask.getDagNodeId();
+ }
protected abstract S initialize(DagManagementStateStore
dagManagementStateStore) throws IOException;
protected abstract T act(DagManagementStateStore dagManagementStateStore, S
state) throws IOException;
- protected abstract void sendNotification(T result, EventSubmitter
eventSubmitter) throws IOException;
Review Comment:
[if this really is
critical](https://github.com/apache/gobblin/pull/3896#discussion_r1538469764),
let's document in code via a comment.
in addition, if we really find little value in the common pattern of `init
-> act -> sendNotification`, then there's likely no need for the generic param
`T` (thus: `void act(DMSS dmss, S state) throws IOE`)
Issue Time Tracking
-------------------
Worklog Id: (was: 911486)
Time Spent: 3h 50m (was: 3h 40m)
> create dag proc for taking actions on job completion
> ----------------------------------------------------
>
> Key: GOBBLIN-2022
> URL: https://issues.apache.org/jira/browse/GOBBLIN-2022
> Project: Apache Gobblin
> Issue Type: Task
> Reporter: Arjun Singh Bora
> Priority: Major
> Time Spent: 3h 50m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
