[
https://issues.apache.org/jira/browse/GOBBLIN-2022?focusedWorklogId=911628&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-911628
]
ASF GitHub Bot logged work on GOBBLIN-2022:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 26/Mar/24 16:01
Start Date: 26/Mar/24 16:01
Worklog Time Spent: 10m
Work Description: arjun4084346 commented on code in PR #3896:
URL: https://github.com/apache/gobblin/pull/3896#discussion_r1539557387
##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/task/DagTask.java:
##########
@@ -42,11 +43,14 @@ public abstract class DagTask {
@Getter public final DagActionStore.DagAction dagAction;
private final MultiActiveLeaseArbiter.LeaseObtainedStatus
leaseObtainedStatus;
@Getter protected final DagManager.DagId dagId;
+ @Getter protected final DagNodeId dagNodeId;
public DagTask(DagActionStore.DagAction dagAction,
MultiActiveLeaseArbiter.LeaseObtainedStatus leaseObtainedStatus) {
this.dagAction = dagAction;
this.leaseObtainedStatus = leaseObtainedStatus;
this.dagId = DagManagerUtils.generateDagId(dagAction.getFlowGroup(),
dagAction.getFlowName(), dagAction.getFlowExecutionId());
+ this.dagNodeId = new DagNodeId(dagAction.getFlowGroup(),
dagAction.getFlowName(),
+ Long.parseLong(dagAction.getFlowExecutionId()),
dagAction.getFlowGroup(), dagAction.getJobName());
Review Comment:
DagNodeId cannot be returned from DagAction class due to circular dependency
issue.
I need to move DagAction from gobblin-runtime to gobblin-service to be able
to do that, which makes sense because DA belongs to gaas. Should I go ahead?
Issue Time Tracking
-------------------
Worklog Id: (was: 911628)
Time Spent: 6h 20m (was: 6h 10m)
> create dag proc for taking actions on job completion
> ----------------------------------------------------
>
> Key: GOBBLIN-2022
> URL: https://issues.apache.org/jira/browse/GOBBLIN-2022
> Project: Apache Gobblin
> Issue Type: Task
> Reporter: Arjun Singh Bora
> Priority: Major
> Time Spent: 6h 20m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
