[
https://issues.apache.org/jira/browse/GOBBLIN-2024?focusedWorklogId=911705&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-911705
]
ASF GitHub Bot logged work on GOBBLIN-2024:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 26/Mar/24 22:26
Start Date: 26/Mar/24 22:26
Worklog Time Spent: 10m
Work Description: codecov-commenter commented on PR #3902:
URL: https://github.com/apache/gobblin/pull/3902#issuecomment-2021575992
##
[Codecov](https://app.codecov.io/gh/apache/gobblin/pull/3902?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
Report
Attention: Patch coverage is `31.57895%` with `13 lines` in your changes are
missing coverage. Please review.
> Project coverage is 41.28%. Comparing base
[(`fbd4ee8`)](https://app.codecov.io/gh/apache/gobblin/commit/fbd4ee8e8b7a57d5f44f6cf0e887d0eb029b94aa?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
to head
[(`7876342`)](https://app.codecov.io/gh/apache/gobblin/pull/3902?dropdown=coverage&src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
> Report is 1 commits behind head on master.
|
[Files](https://app.codecov.io/gh/apache/gobblin/pull/3902?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
| Patch % | Lines |
|---|---|---|
|
[...org/apache/gobblin/iceberg/GobblinMCEProducer.java](https://app.codecov.io/gh/apache/gobblin/pull/3902?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z29iYmxpbi1pY2ViZXJnL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2ljZWJlcmcvR29iYmxpbk1DRVByb2R1Y2VyLmphdmE=)
| 0.00% | [10 Missing :warning:
](https://app.codecov.io/gh/apache/gobblin/pull/3902?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
|
|
[...org/apache/gobblin/iceberg/Utils/IcebergUtils.java](https://app.codecov.io/gh/apache/gobblin/pull/3902?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z29iYmxpbi1pY2ViZXJnL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2ljZWJlcmcvVXRpbHMvSWNlYmVyZ1V0aWxzLmphdmE=)
| 33.33% | [1 Missing and 1 partial :warning:
](https://app.codecov.io/gh/apache/gobblin/pull/3902?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
|
|
[...pache/gobblin/iceberg/writer/GobblinMCEWriter.java](https://app.codecov.io/gh/apache/gobblin/pull/3902?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z29iYmxpbi1pY2ViZXJnL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2ljZWJlcmcvd3JpdGVyL0dvYmJsaW5NQ0VXcml0ZXIuamF2YQ==)
| 80.00% | [1 Missing :warning:
](https://app.codecov.io/gh/apache/gobblin/pull/3902?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
|
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #3902 +/- ##
============================================
- Coverage 46.61% 41.28% -5.34%
+ Complexity 11217 2192 -9025
============================================
Files 2240 475 -1765
Lines 88334 20174 -68160
Branches 9672 2337 -7335
============================================
- Hits 41181 8328 -32853
+ Misses 43441 10962 -32479
+ Partials 3712 884 -2828
```
</details>
[:umbrella: View full report in Codecov by
Sentry](https://app.codecov.io/gh/apache/gobblin/pull/3902?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it
here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
Issue Time Tracking
-------------------
Worklog Id: (was: 911705)
Time Spent: 1h (was: 50m)
> Improve the performance of GobblinMCEWriter
> -------------------------------------------
>
> Key: GOBBLIN-2024
> URL: https://issues.apache.org/jira/browse/GOBBLIN-2024
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: Zihan Li
> Priority: Major
> Time Spent: 1h
> Remaining Estimate: 0h
>
> We are seeing slowness in the GobblinMCEWriter, which will cause us huge
> backlog when handling large topic and affect the other topics in the same
> container for GMIP. After benchmark, we identify that we can improve the
> computeSpec part to reduce the duplicate work, also we can add the file size
> information in GMCE to avoid calling HDFS for each file.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
