[ 
https://issues.apache.org/jira/browse/GOBBLIN-2022?focusedWorklogId=911720&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-911720
 ]

ASF GitHub Bot logged work on GOBBLIN-2022:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 27/Mar/24 05:35
            Start Date: 27/Mar/24 05:35
    Worklog Time Spent: 10m 
      Work Description: phet commented on code in PR #3896:
URL: https://github.com/apache/gobblin/pull/3896#discussion_r1540493565


##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/task/DagTask.java:
##########
@@ -42,11 +43,14 @@ public abstract class DagTask {
   @Getter public final DagActionStore.DagAction dagAction;
   private final MultiActiveLeaseArbiter.LeaseObtainedStatus 
leaseObtainedStatus;
   @Getter protected final DagManager.DagId dagId;
+  @Getter protected final DagNodeId dagNodeId;

Review Comment:
   caching seems more reasonable in `DagProc`, where it's actually used





Issue Time Tracking
-------------------

    Worklog Id:     (was: 911720)
    Time Spent: 8h 40m  (was: 8.5h)

> create dag proc for taking actions on job completion
> ----------------------------------------------------
>
>                 Key: GOBBLIN-2022
>                 URL: https://issues.apache.org/jira/browse/GOBBLIN-2022
>             Project: Apache Gobblin
>          Issue Type: Task
>            Reporter: Arjun Singh Bora
>            Priority: Major
>          Time Spent: 8h 40m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to