phet commented on code in PR #3896:
URL: https://github.com/apache/gobblin/pull/3896#discussion_r1540495842
##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/proc/DagProc.java:
##########
@@ -46,18 +50,21 @@ public final void process(DagManagementStateStore
dagManagementStateStore) throw
S state = initialize(dagManagementStateStore); // todo - retry
T result = act(dagManagementStateStore, state); // todo - retry
commit(dagManagementStateStore, result); // todo - retry
- sendNotification(result, eventSubmitter); // todo - retry
log.info("{} successfully concluded actions for dagId : {}",
getClass().getSimpleName(), getDagId());
}
- protected abstract DagManager.DagId getDagId();
+ protected DagManager.DagId getDagId() {
+ return this.dagTask.getDagId();
+ }
+
+ protected DagNodeId getDagNodeId() {
+ return this.dagTask.getDagNodeId();
+ }
Review Comment:
in a perfect world we'd have reuse by implementing `FlowId`, `DagId`, and
`DagNodeId` in terms of each other (using OO composition). e.g.:
```
@Data
class DagId {
private final FlowId flowId;
private final String flowExecutionId;
}
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
