[
https://issues.apache.org/jira/browse/GOBBLIN-2022?focusedWorklogId=911737&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-911737
]
ASF GitHub Bot logged work on GOBBLIN-2022:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 27/Mar/24 06:43
Start Date: 27/Mar/24 06:43
Worklog Time Spent: 10m
Work Description: phet commented on code in PR #3896:
URL: https://github.com/apache/gobblin/pull/3896#discussion_r1540534773
##########
gobblin-service/src/main/java/org/apache/gobblin/service/monitoring/KafkaJobStatusMonitor.java:
##########
@@ -193,7 +194,7 @@ protected void
processMessage(DecodeableKafkaRecord<byte[],byte[]> message) {
org.apache.gobblin.configuration.State jobStatus =
parseJobStatus(gobblinTrackingEvent);
if (jobStatus != null) {
try (Timer.Context context =
getMetricContext().timer(GET_AND_SET_JOB_STATUS).time()) {
- addJobStatusToStateStore(jobStatus, this.stateStore,
this.eventProducer, this.dagActionStore);
+ addJobStatusToStateStore(jobStatus, this.stateStore,
this.eventProducer, this.dagActionStore, this.dagProcEngineEnabled);
Review Comment:
rather than pass one more param to this `static` which appears to have been
designed in the main to be `@VisibleForTesting`, I had suggested passing in two
fewer params, `this.eventProducer` and `this.dagActionStore`. then have it
return `Optional<JobStatus>`, present only when the job state newly
transitioned to final.
the resulting `static` method would be much more cohesive (and testable!),
as it solely updates the job state store, without performing side-effects
anywhere else
Issue Time Tracking
-------------------
Worklog Id: (was: 911737)
Time Spent: 10h 40m (was: 10.5h)
> create dag proc for taking actions on job completion
> ----------------------------------------------------
>
> Key: GOBBLIN-2022
> URL: https://issues.apache.org/jira/browse/GOBBLIN-2022
> Project: Apache Gobblin
> Issue Type: Task
> Reporter: Arjun Singh Bora
> Priority: Major
> Time Spent: 10h 40m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
