[
https://issues.apache.org/jira/browse/GOBBLIN-2027?focusedWorklogId=911927&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-911927
]
ASF GitHub Bot logged work on GOBBLIN-2027:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 27/Mar/24 21:57
Start Date: 27/Mar/24 21:57
Worklog Time Spent: 10m
Work Description: arjun4084346 commented on code in PR #3904:
URL: https://github.com/apache/gobblin/pull/3904#discussion_r1542093336
##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/DagManagementTaskStreamImpl.java:
##########
@@ -93,22 +91,22 @@ public DagTask next() {
throw new RuntimeException("DagManagement not initialized in
multi-active execution mode when required.");
}
try {
- MultiActiveLeaseArbiter.LeaseAttemptStatus leaseAttemptStatus = null;
+ LeaseAttemptStatus leaseAttemptStatus = null;
Review Comment:
The only motivation was that there were too many (inner) classes in one
file, total 4.
and to access LeaseObtainedStatus, one would have to write
`MultiActiveLeaseArbiter.LeaseObtainedStatus` while imo
`LeaseAttemptStatus.LeaseObtainedStatus` makes more sense, because it is closer
to `LeaseObtainedStatus` than to `MultiActiveLeaseArbiter`
Issue Time Tracking
-------------------
Worklog Id: (was: 911927)
Time Spent: 40m (was: 0.5h)
> move DagActionStore from gobblin-runtime to gobblin-service
> -----------------------------------------------------------
>
> Key: GOBBLIN-2027
> URL: https://issues.apache.org/jira/browse/GOBBLIN-2027
> Project: Apache Gobblin
> Issue Type: Task
> Reporter: Arjun Singh Bora
> Priority: Major
> Time Spent: 40m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
