[
https://issues.apache.org/jira/browse/GOBBLIN-2019?focusedWorklogId=912292&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-912292
]
ASF GitHub Bot logged work on GOBBLIN-2019:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 29/Mar/24 18:43
Start Date: 29/Mar/24 18:43
Worklog Time Spent: 10m
Work Description: arjun4084346 commented on code in PR #3899:
URL: https://github.com/apache/gobblin/pull/3899#discussion_r1544767114
##########
gobblin-service/src/main/java/org/apache/gobblin/service/monitoring/DagActionStoreChangeMonitor.java:
##########
@@ -180,6 +180,7 @@ protected void processMessage(DecodeableKafkaRecord
message) {
String flowGroup = value.getFlowGroup();
String flowName = value.getFlowName();
String flowExecutionId = value.getFlowExecutionId();
+ String jobName = value.getJobName();
Review Comment:
will it give error if we do not change the table?
should we have a try/catch so it does not fail when expecting old/new
schema? it should work in case of rollback's (due to any unrelated problem),
the rollback should not require to roll back the table change and accept both
old/new schemas
Issue Time Tracking
-------------------
Worklog Id: (was: 912292)
Time Spent: 40m (was: 0.5h)
> Remove Circular Dependency & Initialize multi-active execution classes
> ----------------------------------------------------------------------
>
> Key: GOBBLIN-2019
> URL: https://issues.apache.org/jira/browse/GOBBLIN-2019
> Project: Apache Gobblin
> Issue Type: Improvement
> Components: gobblin-service
> Reporter: Urmi Mustafi
> Assignee: Abhishek Tiwari
> Priority: Major
> Time Spent: 40m
> Remaining Estimate: 0h
>
> The following PR removes a circular dependency between
> {{dagManagementTaskStream & }}{{{}ReminderSettingDagProcLeaseArbiter{}}}{{{}.
> {}}}
> describing the circular dependency: {{dagManagementTaskStream}} uses
> {{ReminderSettingDagProcLeaseArbiter}} to obtain lease, if it fails to obtain
> lease then the {{ReminderSettingDagProcLeaseArbiter}} was setting reminder on
> {{DagActionReminderScheduler}} and when reminder fires add the action back to
> {{{}dagManagementTaskStream{}}}. To remove circular dependency, I remove the
> {{ReminderSettingDagProcLeaseArbiter}} and use the more generic
> {{InstrumentedLeaseArbiter}} that will only provide the status. Instead,
> {{dagManagementTaskStream}} will call {{DagActionReminderScheduler}} to set
> reminders and re-add to task stream
> other changes
> * refactor {{MySqlMultiActiveLeaseArbiter}} and it's initialization to
> specify table names through a prefix to differentiate btwn multiple instances
> * adds {{jobName}} to {{dagActionChangeEvent}}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
