[
https://issues.apache.org/jira/browse/GOBBLIN-2026?focusedWorklogId=912753&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-912753
]
ASF GitHub Bot logged work on GOBBLIN-2026:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 03/Apr/24 00:32
Start Date: 03/Apr/24 00:32
Worklog Time Spent: 10m
Work Description: codecov-commenter commented on PR #3913:
URL: https://github.com/apache/gobblin/pull/3913#issuecomment-2033337439
##
[Codecov](https://app.codecov.io/gh/apache/gobblin/pull/3913?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
Report
Attention: Patch coverage is `50.00000%` with `2 lines` in your changes are
missing coverage. Please review.
> Project coverage is 47.22%. Comparing base
[(`ed66943`)](https://app.codecov.io/gh/apache/gobblin/commit/ed66943824c96a591bf53c071f0be1f086e5ef62?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
to head
[(`c2ff665`)](https://app.codecov.io/gh/apache/gobblin/pull/3913?dropdown=coverage&src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
> Report is 8 commits behind head on master.
|
[Files](https://app.codecov.io/gh/apache/gobblin/pull/3913?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
| Patch % | Lines |
|---|---|---|
|
[...blin/data/management/retention/DatasetCleaner.java](https://app.codecov.io/gh/apache/gobblin/pull/3913?src=pr&el=tree&filepath=gobblin-data-management%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fgobblin%2Fdata%2Fmanagement%2Fretention%2FDatasetCleaner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z29iYmxpbi1kYXRhLW1hbmFnZW1lbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vZGF0YS9tYW5hZ2VtZW50L3JldGVudGlvbi9EYXRhc2V0Q2xlYW5lci5qYXZh)
| 0.00% | [2 Missing :warning:
](https://app.codecov.io/gh/apache/gobblin/pull/3913?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
|
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #3913 +/- ##
============================================
+ Coverage 46.62% 47.22% +0.59%
+ Complexity 11220 8086 -3134
============================================
Files 2241 1550 -691
Lines 88336 61287 -27049
Branches 9672 6941 -2731
============================================
- Hits 41189 28942 -12247
+ Misses 43437 29668 -13769
+ Partials 3710 2677 -1033
```
</details>
[:umbrella: View full report in Codecov by
Sentry](https://app.codecov.io/gh/apache/gobblin/pull/3913?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it
here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
Issue Time Tracking
-------------------
Worklog Id: (was: 912753)
Time Spent: 20m (was: 10m)
> Retention Job should fail on OOM
> --------------------------------
>
> Key: GOBBLIN-2026
> URL: https://issues.apache.org/jira/browse/GOBBLIN-2026
> Project: Apache Gobblin
> Issue Type: Improvement
> Components: misc
> Reporter: Arpit Varshney
> Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Currently, while cleaning the log files, the Retention job goes into OOM and
> silently fails when the no of log files is too many. Workflow execution even
> after failure says Success.
> As the job silently fails, user doesn't get to know explicitly about it.
> Hence, when going into OOM, retention job should explicitly fail if it can't
> be proceeded further
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
