phet commented on code in PR #3901:
URL: https://github.com/apache/gobblin/pull/3901#discussion_r1552555397
##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/proc/KillDagProc.java:
##########
@@ -69,7 +67,10 @@ protected Optional<Dag<JobExecutionPlan>>
initialize(DagManagementStateStore dag
@Override
protected void act(DagManagementStateStore dagManagementStateStore,
Optional<Dag<JobExecutionPlan>> dag)
throws IOException {
+ log.info("Request to kill " + (this.dagNodeId.isPresent() ? " dag node " +
getDagNodeId() : " dag " + getDagId()));
Review Comment:
doesn't the `dagId` always come into play (for lookup)?
if so, would be good to always log it. also, it's fine to always
`Optional.toString()`, whether or not it's empty
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
