[
https://issues.apache.org/jira/browse/GOBBLIN-2023?focusedWorklogId=913238&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-913238
]
ASF GitHub Bot logged work on GOBBLIN-2023:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 05/Apr/24 16:33
Start Date: 05/Apr/24 16:33
Worklog Time Spent: 10m
Work Description: phet commented on code in PR #3901:
URL: https://github.com/apache/gobblin/pull/3901#discussion_r1553974327
##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/proc/KillDagProc.java:
##########
@@ -67,7 +63,10 @@ protected Optional<Dag<JobExecutionPlan>>
initialize(DagManagementStateStore dag
@Override
protected void act(DagManagementStateStore dagManagementStateStore,
Optional<Dag<JobExecutionPlan>> dag)
throws IOException {
- log.info("Request to kill " + (this.dagNodeId.isPresent() ? " dag node " +
getDagNodeId() : " dag " + getDagId()));
+ log.info("Request to kill dag " + getDagId());
+ if (dagNodeKillRequest) {
+ log.info("Request to kill dag node" + getDagNodeId());
+ }
Review Comment:
let's keep it all part of the same message:
```
log.info("Request to kill dag {} (node: {})", getDagId(),
shouldKillSpecificJob ? getDagNodeId().toString() : "<<all>>")
```
##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/proc/KillDagProc.java:
##########
@@ -48,14 +47,11 @@
*/
@Slf4j
public class KillDagProc extends DagProc<Optional<Dag<JobExecutionPlan>>> {
- private final Optional<DagNodeId> dagNodeId;
+ private final boolean dagNodeKillRequest;
Review Comment:
we've inherited potential confusion because "job" and "dagNode" are
basically synonyms. perhaps we should use "job" for what's exposed to users
(e.g. API endpoints and the DagActions" directly created from those) and
"dagNode" for internal mechanics of carrying out those actions. in this case,
I'd opt for "job" terminology, so maybe `shouldKillSpecificJob`
Issue Time Tracking
-------------------
Worklog Id: (was: 913238)
Time Spent: 1.5h (was: 1h 20m)
> create dag proc that can kill dags/dag nodes
> --------------------------------------------
>
> Key: GOBBLIN-2023
> URL: https://issues.apache.org/jira/browse/GOBBLIN-2023
> Project: Apache Gobblin
> Issue Type: Task
> Reporter: Arjun Singh Bora
> Priority: Major
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
