[
https://issues.apache.org/jira/browse/GOBBLIN-2043?focusedWorklogId=914752&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-914752
]
ASF GitHub Bot logged work on GOBBLIN-2043:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 15/Apr/24 23:51
Start Date: 15/Apr/24 23:51
Worklog Time Spent: 10m
Work Description: ZihanLi58 commented on code in PR #3922:
URL: https://github.com/apache/gobblin/pull/3922#discussion_r1566554722
##########
gobblin-data-management/src/main/java/org/apache/gobblin/data/management/copy/ManifestBasedDataset.java:
##########
@@ -146,6 +151,13 @@ public Iterator<FileSet<CopyEntity>>
getFileSetIterator(FileSystem targetFs, Cop
}
}
+ // Only set permission for newly created folders on target
Review Comment:
Let's add command here saying if we want to set permission for existing
folder, we need to put them in the manifest. Also can you help verify that we
support existing folder permission sync in the current job?
Issue Time Tracking
-------------------
Worklog Id: (was: 914752)
Time Spent: 20m (was: 10m)
> Manifest distcp sets permissions of folders incorrectly starting from root
> --------------------------------------------------------------------------
>
> Key: GOBBLIN-2043
> URL: https://issues.apache.org/jira/browse/GOBBLIN-2043
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: William Lo
> Priority: Minor
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Manifest distcp has a condition where it would set permissions of folders
> with an extra execute bit for recursive rename publishing to work, and we and
> would need to unset them to a correct permission through a commit step.
> However process should not be applying to folders that already exist on
> source, and we also want to avoid continuously looking at permissions for
> paths already calculated at source.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
