phet commented on code in PR #3924:
URL: https://github.com/apache/gobblin/pull/3924#discussion_r1569095939
##########
gobblin-temporal/src/main/java/org/apache/gobblin/temporal/ddm/work/assistance/Help.java:
##########
@@ -247,4 +251,32 @@ protected static void
doGaaSFlowExecutionContextPropagation(String flowGroup, St
MDC.put(ConfigurationKeys.FLOW_NAME_KEY,
String.format("%s:%s",ConfigurationKeys.FLOW_NAME_KEY, flowName));
MDC.put(ConfigurationKeys.FLOW_EXECUTION_ID_KEY,
String.format("%s:%s",ConfigurationKeys.FLOW_EXECUTION_ID_KEY, flowExecId));
}
+
+ /**
+ * refine {@link AutomaticTroubleshooter} issues then report them to the
{@link EventSubmitter} and log an issues summary via `logger`;
+ * gracefully handle `null` `troubleshooter`
+ */
+ public static void finalizeTroubleshooting(AutomaticTroubleshooter
troubleshooter, EventSubmitter eventSubmitter, Logger logger, String
correlator) {
+ try {
+ if (troubleshooter == null) {
+ logger.warn("{} - No troubleshooter to report issues from automatic
troubleshooter", correlator);
Review Comment:
agreed on that! but this here is warning that the troubleshooter was never
initialized. hence there may or may not have been issues, but in either case
no reporting would happen. this calls out loudly that "no news" isn't
necessarily "good news"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
