[
https://issues.apache.org/jira/browse/GOBBLIN-2049?focusedWorklogId=915423&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-915423
]
ASF GitHub Bot logged work on GOBBLIN-2049:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 19/Apr/24 00:45
Start Date: 19/Apr/24 00:45
Worklog Time Spent: 10m
Work Description: phet commented on code in PR #3929:
URL: https://github.com/apache/gobblin/pull/3929#discussion_r1571563487
##########
gobblin-data-management/src/main/java/org/apache/gobblin/data/management/copy/publisher/CopyDataPublisher.java:
##########
@@ -95,7 +95,7 @@ public boolean isThreadSafe() {
protected final DataFileVersionStrategy dstDataFileVersionStrategy;
protected final boolean preserveDirModTime;
protected final boolean resyncDirOwnerAndPermission;
- protected final boolean requirePermissionSetForSuccess;
+ protected final boolean shouldFailWhenPermissionFail;
Review Comment:
nit: when permission***s*** fail (preferred!) or when permission fail***s***
Issue Time Tracking
-------------------
Worklog Id: (was: 915423)
Time Spent: 1h (was: 50m)
> Configure Gobblin Distcp Writer to fail if setPermission fails
> --------------------------------------------------------------
>
> Key: GOBBLIN-2049
> URL: https://issues.apache.org/jira/browse/GOBBLIN-2049
> Project: Apache Gobblin
> Issue Type: New Feature
> Components: gobblin-service
> Reporter: Urmi Mustafi
> Assignee: Abhishek Tiwari
> Priority: Major
> Time Spent: 1h
> Remaining Estimate: 0h
>
> Gobblin {{safeSetPathPermission}} does not throw an exception when setting
> permissions fail on a path. We want to change this behavior especially for
> use cases like manifest distcp where hundreds of thousands of files are
> involved in a distcp job and permission settings are important to replicate
> correctly as they cannot be updated or verified by hand.
> This PR adds a new configuration to fail writing or publishing tasks when the
> job is configured to report success when permissions are not replicated
> properly. The default behavior remains the same as before to allow the job to
> succeed without this for backwards compatibility.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
