[
https://issues.apache.org/jira/browse/GOBBLIN-2053?focusedWorklogId=916247&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-916247
]
ASF GitHub Bot logged work on GOBBLIN-2053:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 24/Apr/24 19:54
Start Date: 24/Apr/24 19:54
Worklog Time Spent: 10m
Work Description: phet commented on code in PR #3933:
URL: https://github.com/apache/gobblin/pull/3933#discussion_r1578431518
##########
gobblin-api/src/main/java/org/apache/gobblin/configuration/ConfigurationKeys.java:
##########
@@ -913,9 +913,8 @@ public class ConfigurationKeys {
public static final String METRICS_REPORTING_OPENTELEMETRY_ENDPOINT =
METRICS_REPORTING_OPENTELEMETRY_PREFIX + "endpoint";
- public static final String METRICS_REPORTING_OPENTELEMETRY_HEADER_KEY =
METRICS_REPORTING_OPENTELEMETRY_PREFIX + "header.key";
-
- public static final String METRICS_REPORTING_OPENTELEMETRY_HEADER_VALUE =
METRICS_REPORTING_OPENTELEMETRY_PREFIX + "header.value";
+ // Headers to add to the OpenTelemetry HTTP Exporter, formatted as a JSON
String
Review Comment:
specifically is it supposed to be a JSON dictionary of string, to string?
(whatever it is, doc)
Issue Time Tracking
-------------------
Worklog Id: (was: 916247)
Remaining Estimate: 0h
Time Spent: 10m
> Fix config setup to Opentelemetry metric emitter
> ------------------------------------------------
>
> Key: GOBBLIN-2053
> URL: https://issues.apache.org/jira/browse/GOBBLIN-2053
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: William Lo
> Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Opentelemetry event submitter which is used in GaaS was not propagating
> certain tags and attributes correctly to connect to external sources.
> We want to do the following:
> 1. Add some logging when the emitter is initialized successfully
> 2. Enforce a URL if it is enabled so that it can emit to an endpoint (not
> localhost)
> 3. Allow the user to specify headers in JSON format for forwarding metrics to
> a metrics aggregator (e.g. Fluentbit)
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
