phet commented on code in PR #3931:
URL: https://github.com/apache/gobblin/pull/3931#discussion_r1578543298
##########
gobblin-service/src/main/java/org/apache/gobblin/service/monitoring/GaaSObservabilityEventProducer.java:
##########
@@ -99,6 +99,7 @@ protected OpenTelemetryMetricsBase
getOpentelemetryMetrics(State state) {
private void setupMetrics(State state) {
this.opentelemetryMetrics = getOpentelemetryMetrics(state);
if (this.opentelemetryMetrics != null) {
+ log.info("Setting up Opentelemetry metrics");
Review Comment:
did these changes sneak in?
##########
gobblin-cluster/src/main/java/org/apache/gobblin/cluster/GobblinClusterConfigurationKeys.java:
##########
@@ -50,6 +50,8 @@ public class GobblinClusterConfigurationKeys {
public static final boolean DEFAULT_STANDALONE_CLUSTER_MODE = false;
// Root working directory for Gobblin cluster
public static final String CLUSTER_WORK_DIR = GOBBLIN_CLUSTER_PREFIX +
"workDir";
+ // Root working dir without appending the application name, keeping
CLUSTER_WORK_DIR property for backward compatibility
Review Comment:
documenting an example might help illustrate the semantic difference between
the two props (and let people decide when they want each).
##########
gobblin-yarn/src/main/java/org/apache/gobblin/yarn/GobblinYarnAppLauncher.java:
##########
@@ -885,10 +884,11 @@ private AbstractTokenRefresher buildTokenRefreshManager()
throws IOException {
@VisibleForTesting
void cleanUpAppWorkDirectory(ApplicationId applicationId) throws IOException
{
- Path appWorkDir =
GobblinClusterUtils.getAppWorkDirPathFromConfig(this.config, this.fs,
this.applicationName, applicationId.toString());
- if (this.fs.exists(appWorkDir)) {
+ FileSystem fs =
GobblinClusterUtils.buildNewInstanceFileSystem(this.config,
this.yarnConfiguration);
Review Comment:
let's document that we found the other FS instance was closed by the YARN
app and couldn't be reused!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
