arjun4084346 commented on code in PR #3937:
URL: https://github.com/apache/gobblin/pull/3937#discussion_r1585928379
##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/flow/BaseFlowToJobSpecCompiler.java:
##########
@@ -97,35 +97,13 @@ public abstract class BaseFlowToJobSpecCompiler implements
SpecCompiler {
private Optional<UserQuotaManager> userQuotaManager;
- public BaseFlowToJobSpecCompiler(Config config){
- this(config,true);
- }
-
- public BaseFlowToJobSpecCompiler(Config config, boolean
instrumentationEnabled){
- this(config, Optional.<Logger>absent(), true);
- }
-
- public BaseFlowToJobSpecCompiler(Config config, Optional<Logger> log){
- this(config, log,true);
- }
-
- public BaseFlowToJobSpecCompiler(Config config, Optional<Logger> log,
boolean instrumentationEnabled){
- this.log = log.isPresent() ? log.get() :
LoggerFactory.getLogger(getClass());
- if (instrumentationEnabled) {
Review Comment:
1) yes, in https://github.com/apache/gobblin/pull/3855/files I made some
optional fields mandatory. instrumentationEnabled was not one of them, but
eventSubmitter was which is related.
2) instrumentationEnabled is usually true in prod, these variables are set
false only for doing easier tests.
3) Also, in this particular case, instrumentationEnabled was hard coded to
`true` in the above above constructor anyway.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
