[
https://issues.apache.org/jira/browse/GOBBLIN-2061?focusedWorklogId=917854&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-917854
]
ASF GitHub Bot logged work on GOBBLIN-2061:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 06/May/24 15:53
Start Date: 06/May/24 15:53
Worklog Time Spent: 10m
Work Description: umustafi commented on code in PR #3943:
URL: https://github.com/apache/gobblin/pull/3943#discussion_r1591207481
##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/proc/LaunchDagProc.java:
##########
@@ -63,8 +63,12 @@ protected Optional<Dag<JobExecutionPlan>>
initialize(DagManagementStateStore dag
try {
FlowSpec flowSpec =
dagManagementStateStore.getFlowSpec(FlowSpec.Utils.createFlowSpecUri(getDagId().getFlowId()));
flowSpec.addProperty(ConfigurationKeys.FLOW_EXECUTION_ID_KEY,
getDagId().getFlowExecutionId());
- return
this.flowCompilationValidationHelper.createExecutionPlanIfValid(flowSpec).toJavaUtil();
- } catch (URISyntaxException | SpecNotFoundException | InterruptedException
e) {
+ Optional<Dag<JobExecutionPlan>> dag =
this.flowCompilationValidationHelper.createExecutionPlanIfValid(flowSpec).toJavaUtil();
+ if (dag.isPresent()) {
+ dagManagementStateStore.checkpointDag(dag.get());
+ }
+ return dag;
Review Comment:
I can simplify it to return optional.Empty explicitly. The approach you
suggested doesn't work without explicitly surrounding the lambda with another
try catch block (I can't add the exception to the existing try/catch block)
which becomes slightly messy. wdyt?
Issue Time Tracking
-------------------
Worklog Id: (was: 917854)
Time Spent: 50m (was: 40m)
> Fix initialization of DagProcessingEngine
> -----------------------------------------
>
> Key: GOBBLIN-2061
> URL: https://issues.apache.org/jira/browse/GOBBLIN-2061
> Project: Apache Gobblin
> Issue Type: Bug
> Components: gobblin-service
> Reporter: Urmi Mustafi
> Assignee: Abhishek Tiwari
> Priority: Major
> Time Spent: 50m
> Remaining Estimate: 0h
>
> * Initialize DagProcessingEngine with right parameters
> * Add DagProcessingEngine to GobblinServiceManager
> * Add logging to DagProcessingEngine instantiation and Threads
> * Fix instantiation of QuartzScheduler for DagActionReminderScheduler
> * Fix DagAction type retrieval from Quartz reminder job detail map
> *
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
