phet commented on code in PR #3945:
URL: https://github.com/apache/gobblin/pull/3945#discussion_r1593291128
##########
gobblin-modules/gobblin-kafka-09/src/test/java/org/apache/gobblin/runtime/KafkaAvroJobStatusMonitorTest.java:
##########
@@ -339,8 +339,7 @@ public void
testProcessingRetriedForApparentlyTransientErrors() throws IOExcepti
Config conf = ConfigFactory.empty().withValue(
KafkaJobStatusMonitor.JOB_STATUS_MONITOR_PREFIX + "." +
RETRY_MULTIPLIER,
ConfigValueFactory.fromAnyRef(TimeUnit.MILLISECONDS.toMillis(1L)));
MockKafkaAvroJobStatusMonitor jobStatusMonitor =
createMockKafkaAvroJobStatusMonitor(shouldThrowFakeExceptionInParseJobStatusToggle,
conf,
- new
org.apache.gobblin.service.monitoring.NoopGaaSJobObservabilityEventProducer());
- jobStatusMonitor.buildMetricsContextAndMetrics();
+ new NoopGaaSJobObservabilityEventProducer()ntextAndMetrics();
Review Comment:
did like the method `[buildMetricsCo]ntextAndMetrics()` get truncated?
##########
gobblin-modules/gobblin-kafka-09/src/test/java/org/apache/gobblin/runtime/KafkaAvroJobStatusMonitorTest.java:
##########
@@ -339,8 +339,7 @@ public void
testProcessingRetriedForApparentlyTransientErrors() throws IOExcepti
Config conf = ConfigFactory.empty().withValue(
KafkaJobStatusMonitor.JOB_STATUS_MONITOR_PREFIX + "." +
RETRY_MULTIPLIER,
ConfigValueFactory.fromAnyRef(TimeUnit.MILLISECONDS.toMillis(1L)));
MockKafkaAvroJobStatusMonitor jobStatusMonitor =
createMockKafkaAvroJobStatusMonitor(shouldThrowFakeExceptionInParseJobStatusToggle,
conf,
- new
org.apache.gobblin.service.monitoring.NoopGaaSJobObservabilityEventProducer());
- jobStatusMonitor.buildMetricsContextAndMetrics();
+ new NoopGaaSJobObservabilityEventProducer()ntextAndMetrics();
Review Comment:
did the method `[buildMetricsCo]ntextAndMetrics()` get truncated?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
