phet commented on code in PR #3912:
URL: https://github.com/apache/gobblin/pull/3912#discussion_r1599160143
##########
gobblin-temporal/src/main/java/org/apache/gobblin/temporal/ddm/activity/CommitActivity.java:
##########
@@ -32,5 +34,5 @@ public interface CommitActivity {
* @return number of workunits committed
*/
@ActivityMethod
- int commit(WUProcessingSpec workSpec);
+ CommitGobblinStats commit(WUProcessingSpec workSpec);
Review Comment:
to me, "gobblin commit stats" sounds better than ""commit gobblin stats",
since "of all the gobblin stats, these are the commit ones", more so than "of
all the commit stats these are gobblin ones".
that said, as everything is within our gobblin impl, this could probably be
simply `CommitStats`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
