[
https://issues.apache.org/jira/browse/GOBBLIN-2067?focusedWorklogId=919377&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-919377
]
ASF GitHub Bot logged work on GOBBLIN-2067:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 14/May/24 19:09
Start Date: 14/May/24 19:09
Worklog Time Spent: 10m
Work Description: phet commented on code in PR #3947:
URL: https://github.com/apache/gobblin/pull/3947#discussion_r1600525706
##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/core/GobblinServiceManager.java:
##########
@@ -117,7 +117,7 @@ public class GobblinServiceManager implements
ApplicationLauncher, StandardMetri
public static final String SERVICE_EVENT_BUS_NAME =
"GobblinServiceManagerEventBus";
private static final Logger LOGGER =
LoggerFactory.getLogger(GobblinServiceManager.class);
- private static volatile GobblinServiceGuiceModule
GOBBLIN_SERVICE_GUICE_MODULE;
+ @Setter private static volatile GobblinServiceGuiceModule
GOBBLIN_SERVICE_GUICE_MODULE;
Review Comment:
not seeing where this is used... did I miss something?
##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/core/GobblinServiceManager.java:
##########
@@ -530,7 +531,7 @@ public void start() throws ApplicationException {
this.orchestrator.getSpecCompiler().setActive(true);
//Activate the DagManager service, after the topologyCatalog has been
initialized.
Review Comment:
please add a comment explaining we don't want to start DM threads (e.g. as
mentioned in the PR desc)
Issue Time Tracking
-------------------
Worklog Id: (was: 919377)
Remaining Estimate: 0h
Time Spent: 10m
> do not try to get dags during MostlyMySqlDagManagementStateStore
> initialization
> -------------------------------------------------------------------------------
>
> Key: GOBBLIN-2067
> URL: https://issues.apache.org/jira/browse/GOBBLIN-2067
> Project: Apache Gobblin
> Issue Type: Bug
> Reporter: Arjun Singh Bora
> Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
