homatthew commented on code in PR #3949:
URL: https://github.com/apache/gobblin/pull/3949#discussion_r1602394492
##########
gobblin-iceberg/src/main/java/org/apache/gobblin/iceberg/publisher/GobblinMCEPublisher.java:
##########
@@ -115,9 +115,11 @@ public void publishData(Collection<? extends
WorkUnitState> states) throws IOExc
}
protected Map<String, String> getPartitionOffsetRange(String offsetKey) {
- return state.getPropAsList(offsetKey)
Review Comment:
Ah, in that case "orElse(null)" is what you'd want.
But either way, seems like this is a headache to handle since everything
can't handle null 😆 . Java stream / optional API can only help so much
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
