umustafi commented on PR #3950:
URL: https://github.com/apache/gobblin/pull/3950#issuecomment-2121090432
One concern I have is to make sure we use the idea for "reminder" in the
`DagActionReminderScheduler` properly with the MALA. For MALA a reminder means
that there's an existing entry in lease table (however for deadlines there was
no existing lease attempt so it will complete as if it was a new event).
1) all actions in the `DagActionReminderScheduler` are for reminder events
-> u added a field to `DagAction` to know its a reminder
2) we attempt lease when the reminder trigger fires in the
`DagActionReminderScheduler`
3) need to pass the reminder flag to the MALA so it handles lease
arbitration correctly
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
