umustafi opened a new pull request, #3951: URL: https://github.com/apache/gobblin/pull/3951
… flowExecutionId is different than the event time of the lease Dear Gobblin maintainers, Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below! ### JIRA - [ ] My PR addresses the following [Gobblin JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR" - https://issues.apache.org/jira/browse/GOBBLIN-XXX ### Description - [X] Here are some details about my PR, including screenshots (if applicable): We are using the `flowExecutionId` from a `LeaseObtainedStatus` as the `eventTimestamp` to attempt to complete the lease at a later time. However, this only works for scheduled flows where we adopt the `consensus eventTimestamp` as the `flowExecutionId`. For adhoc flows, we do not update the id and the two values may be different so lease completion fails by the current owner of the lease. This PR keeps track of the `eventTimestamp` from the lease arbiter to prevent any confusion. ### Tests - [X] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason: TODO ### Commits - [X] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)": 1. Subject is separated from body by a blank line 2. Subject is limited to 50 characters 3. Subject does not end with a period 4. Subject uses the imperative mood ("add", not "adding") 5. Body wraps at 72 characters 6. Body explains "what" and "why", not "how" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
