umustafi commented on code in PR #3950:
URL: https://github.com/apache/gobblin/pull/3950#discussion_r1610817832
##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/DagManagementTaskStreamImpl.java:
##########
@@ -138,7 +138,11 @@ public DagTask next() {
createJobStartDeadlineTrigger(dagAction);
} else if (!dagAction.isReminder() && dagAction.dagActionType ==
DagActionStore.DagActionType.ENFORCE_FLOW_FINISH_DEADLINE) {
createFlowFinishDeadlineTrigger(dagAction);
- } else {
+ } else if (!dagAction.isReminder
+ || dagAction.dagActionType ==
DagActionStore.DagActionType.ENFORCE_FLOW_FINISH_DEADLINE
+ || dagAction.dagActionType ==
DagActionStore.DagActionType.ENFORCE_JOB_START_DEADLINE) {
+ // todo - fix bug of a reminder event getting a lease even when
the first attempt succeeded.
+ // for now, avoid processing reminder events if they are not for
deadline dag actions
Review Comment:
I will address this problem in a separate PR for now this will simply give
parity to existing functionality (no MA)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
