arjun4084346 commented on code in PR #3952:
URL: https://github.com/apache/gobblin/pull/3952#discussion_r1613834527
##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/DagManagementTaskStreamImpl.java:
##########
@@ -197,9 +193,11 @@ private void
createFlowFinishDeadlineTrigger(DagActionStore.DagAction dagAction)
*/
private LeaseAttemptStatus retrieveLeaseStatus(DagActionStore.DagAction
dagAction)
throws IOException, SchedulerException {
- // TODO: need to handle reminder events and flag them
+ // Uses reminder flag to determine whether to use current time as event
time or previously saved event time
LeaseAttemptStatus leaseAttemptStatus =
this.dagActionProcessingLeaseArbiter
- .tryAcquireLease(dagAction, System.currentTimeMillis(),
dagAction.isReminder, false);
+ .tryAcquireLease(dagAction,
+ dagAction.isReminder && dagAction.getEventTimeMillis() != 0L ?
dagAction.getEventTimeMillis() : System.currentTimeMillis(),
+ dagAction.isReminder, false);
Review Comment:
eventTimeMillis should also be removed.
`dagAction.isReminder && dagAction.getEventTimeMillis() != 0L ?
dagAction.getEventTimeMillis()` can go inside the method
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
