arjun4084346 commented on code in PR #3954:
URL: https://github.com/apache/gobblin/pull/3954#discussion_r1619202367
##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/MostlyMySqlDagManagementStateStore.java:
##########
@@ -180,9 +181,7 @@ public Set<String> getFailedDagIds() throws IOException {
@Override
// todo - updating different maps here and in addDagNodeState can result in
inconsistency between the maps
public synchronized void deleteDagNodeState(DagManager.DagId dagId,
Dag.DagNode<JobExecutionPlan> dagNode) {
- this.jobToDag.remove(dagNode);
Review Comment:
actually these fields were unused. that's the objective 2 for this PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
