[
https://issues.apache.org/jira/browse/GOBBLIN-2073?focusedWorklogId=921350&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-921350
]
ASF GitHub Bot logged work on GOBBLIN-2073:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 30/May/24 08:35
Start Date: 30/May/24 08:35
Worklog Time Spent: 10m
Work Description: phet commented on code in PR #3952:
URL: https://github.com/apache/gobblin/pull/3952#discussion_r1620172109
##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/DagActionStore.java:
##########
@@ -49,14 +49,25 @@ class DagAction {
final String flowExecutionId;
final String jobName;
final DagActionType dagActionType;
- final boolean isReminder;
+ boolean isReminder;
+ long eventTimeMillis;
Review Comment:
so an instance could exist w/o these fields ever having been set? shouldn't
we prevent this, via `final`?
BTW, what is the "event" behind this time? is it when the API request came
in to say perform a "kill action"? why is it critical to store that?
Issue Time Tracking
-------------------
Worklog Id: (was: 921350)
Time Spent: 50m (was: 40m)
> Add eventTime and reminder fields to DagAction POJO
> ---------------------------------------------------
>
> Key: GOBBLIN-2073
> URL: https://issues.apache.org/jira/browse/GOBBLIN-2073
> Project: Apache Gobblin
> Issue Type: Bug
> Components: gobblin-service
> Reporter: Urmi Mustafi
> Assignee: Abhishek Tiwari
> Priority: Major
> Time Spent: 50m
> Remaining Estimate: 0h
>
> An event timestamp and reminder flag are used in conjunction with DagActions
> for lease arbitration and for reminder dagActions. It makes sense to include
> these fields in the DagAction object itself to easily transfer the
> information from one location to another. In particular for reminder events
> used to check back in on incomplete dagAction leases, these two fields are
> utilized and it's easiest to keep track of them when it's maintained within
> the consensusDagAction returned in a LeaseAttemptStatus
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
