[
https://issues.apache.org/jira/browse/GOBBLIN-2075?focusedWorklogId=921578&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-921578
]
ASF GitHub Bot logged work on GOBBLIN-2075:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 31/May/24 20:00
Start Date: 31/May/24 20:00
Worklog Time Spent: 10m
Work Description: phet commented on code in PR #3956:
URL: https://github.com/apache/gobblin/pull/3956#discussion_r1622899698
##########
gobblin-service/src/test/java/org/apache/gobblin/service/monitoring/GaaSJobObservabilityProducerTest.java:
##########
@@ -136,7 +137,7 @@ public void
testCreateGaaSObservabilityEventWithFullMetadata() throws Exception
Assert.assertEquals(event.getDatasetsMetrics().get(1).getEntitiesWritten(),
Long.valueOf(dataset2.getRecordsWritten()));
Assert.assertEquals(event.getDatasetsMetrics().get(1).getBytesWritten(),
Long.valueOf(dataset2.getBytesWritten()));
Assert.assertEquals(event.getDatasetsMetrics().get(1).getSuccessfullyCommitted(),
Boolean.valueOf(dataset2.isSuccessfullyCommitted()));
- Assert.assertEquals(event.getJobProperties(),
"{\"gobblin.flow.sourceIdentifier\":\"sourceNode\",\"gobblin.flow.destinationIdentifier\":\"destinationNode\",\"user.to.proxy\":\"newUser\",\"flow.executionId\":\"1681242538558\"}");
+ JsonParser.parseString(event.getJobProperties()); // Should not throw
Review Comment:
what are we validating not to throw - the `getJobProperties()` call or the
JSON parsing?
Issue Time Tracking
-------------------
Worklog Id: (was: 921578)
Time Spent: 20m (was: 10m)
> Use FlowGraphConfigurationKeys configs to identify source and dest node for
> observability events
> ------------------------------------------------------------------------------------------------
>
> Key: GOBBLIN-2075
> URL: https://issues.apache.org/jira/browse/GOBBLIN-2075
> Project: Apache Gobblin
> Issue Type: Bug
> Components: gobblin-service
> Reporter: William Lo
> Assignee: Abhishek Tiwari
> Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
> GaaSObservabilityEvents want to send data on source and destination node.
> However, it uses a Service config key that is not present in multihop flow
> compiler. To remedy this, instead use the source and destination node keys
> from the flowgraph
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
