[
https://issues.apache.org/jira/browse/GOBBLIN-2075?focusedWorklogId=921603&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-921603
]
ASF GitHub Bot logged work on GOBBLIN-2075:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 01/Jun/24 00:33
Start Date: 01/Jun/24 00:33
Worklog Time Spent: 10m
Work Description: phet commented on code in PR #3956:
URL: https://github.com/apache/gobblin/pull/3956#discussion_r1623063451
##########
gobblin-service/src/test/java/org/apache/gobblin/service/modules/orchestration/DagManagerUtilsTest.java:
##########
@@ -0,0 +1,36 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.gobblin.service.modules.orchestration;
+
+import org.testng.Assert;
+import org.testng.annotations.Test;
+
+import org.apache.gobblin.runtime.api.JobSpec;
+import org.apache.gobblin.service.modules.flowgraph.Dag;
+import org.apache.gobblin.service.modules.spec.JobExecutionPlan;
+
+
+public class DagManagerUtilsTest {
+
+ @Test
+ public void testGetJobSpecFromDag() throws Exception {
+ Dag<JobExecutionPlan> testDag = DagTestUtils.buildDag("testDag", 1000L);
+ JobSpec jobSpec = DagManagerUtils.getJobSpec(testDag.getNodes().get(0));
+ Assert.assertEquals(jobSpec.getConfigAsProperties().size(),
jobSpec.getConfig().entrySet().size());
Review Comment:
why not assert that they're equal? is that what we expect?
Issue Time Tracking
-------------------
Worklog Id: (was: 921603)
Time Spent: 40m (was: 0.5h)
> JobProperties, source and destination nodes are not reflected in the
> GaaSJobObservabilityEvent
> ----------------------------------------------------------------------------------------------
>
> Key: GOBBLIN-2075
> URL: https://issues.apache.org/jira/browse/GOBBLIN-2075
> Project: Apache Gobblin
> Issue Type: Bug
> Components: gobblin-service
> Reporter: William Lo
> Assignee: Abhishek Tiwari
> Priority: Major
> Time Spent: 40m
> Remaining Estimate: 0h
>
> GaaSObservabilityEvents want to send data on source and destination node, and
> the job properties. They are showing up to only have the retry configurations
> in the DagManager, and no source and destination node. This makes the
> observability event lacking in useful data that makes queries a lot easier
> for source and destination filtering in GaaS
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
