[
https://issues.apache.org/jira/browse/GOBBLIN-2077?focusedWorklogId=921604&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-921604
]
ASF GitHub Bot logged work on GOBBLIN-2077:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 01/Jun/24 00:41
Start Date: 01/Jun/24 00:41
Worklog Time Spent: 10m
Work Description: phet commented on code in PR #3960:
URL: https://github.com/apache/gobblin/pull/3960#discussion_r1623063819
##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/DagManagementTaskStreamImpl.java:
##########
@@ -146,7 +147,7 @@ public DagTask next() {
}
} catch (Exception e) {
//TODO: need to handle exceptions gracefully
- log.error("Exception getting DagAction from the queue / creating
DagTask", e);
+ log.error("Exception getting DagAction from the queue / creating
DagTask {}", dagAction == null ? "" : dagAction, e);
Review Comment:
wouldn't it just print the string `null`? seems clearer and more helpful
indicator when debugging than is empty string
##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/proc/LaunchDagProc.java:
##########
@@ -83,6 +83,7 @@ protected void act(DagManagementStateStore
dagManagementStateStore, Optional<Dag
submitNextNodes(dagManagementStateStore, dag.get());
//Checkpoint the dag state, it should have an updated value of dag nodes
Review Comment:
nit - start comment w/ space
##########
gobblin-service/src/test/java/org/apache/gobblin/service/modules/orchestration/proc/LaunchDagProcTest.java:
##########
@@ -97,6 +99,11 @@ public void launchDag()
Assert.assertEquals(expectedNumOfSavingDagNodeStates,
Mockito.mockingDetails(this.dagManagementStateStore).getInvocations().stream()
.filter(a ->
a.getMethod().getName().equals("addDagNodeState")).count());
+
+ List<Invocation> invocations =
Mockito.mockingDetails(this.dagManagementStateStore).getInvocations().stream()
+ .filter(a ->
a.getMethod().getName().equals("addFlowDagAction")).collect(Collectors.toList());
+ Assert.assertEquals(invocations.size(), 1);
+ Assert.assertEquals(invocations.get(0).getArguments()[3],
DagActionStore.DagActionType.ENFORCE_FLOW_FINISH_DEADLINE);
Review Comment:
doesn't it work to use:
```
Mockito.verify(this.dagManagementStateStore,
Mockito.times(1)).addFlowDagAction(any(), any(), any(),
eq(DAS.DAT.ENFORECE_FLOW_FINISH_DEADLINE));
```
?
Issue Time Tracking
-------------------
Worklog Id: (was: 921604)
Time Spent: 0.5h (was: 20m)
> create flow finish deadline dag action after the launch of first job
> --------------------------------------------------------------------
>
> Key: GOBBLIN-2077
> URL: https://issues.apache.org/jira/browse/GOBBLIN-2077
> Project: Apache Gobblin
> Issue Type: Task
> Reporter: Arjun Singh Bora
> Priority: Major
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
